Support --data-raw
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Just looking at the output for "with-raw-data".
Doesn't the withBody method require 2 parameters?
// Illuminate/Http/Client/PendingRequest.php
/**
* Attach a raw body to the request.
*
* @param string $content
* @param string $contentType
* @return $this
*/
public function withBody($content, $contentType)
{
$this->bodyFormat('body');
$this->pendingBody = $content;
$this->contentType($contentType);
return $this;
}
|
I thought it was optional based on the content type of the request. However, looks like it's not. I'll need to revisit this as I use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--data-rawoption takes some interpretation. Thecurldocs do not state that it is mutually exclusive from--data. From a quick tests, it seemscurlmerges the data when called with both--dataand--data-raw.With that said, the common use case for
--data-rawseems to be independent. When passed alone, this is the exact data to send in the request payload.This PR adds support for
--data-rawto the specification above - parsing it as form data when mixed with--dataor sending it as the raw body when used independently.